On 1/6/26 09:53, Avinal Kumar wrote:
Hello Neil,

Unlike mipi_dsi_turn_on_peripheral, mipi_dsi_shutdown_peripheral isn't marked 
deprecated, and no multi function available yet. And I wanted to keep it simple 
for the first patch.

If it is okay, I can:
- Create another patch or update this patch, to add a 
mipi_dsi_shutdown_peripheral_multi() function and deprecate the normal function.
- Update the remaining function in this patch.

Please let me know. Thank you

Yes please do that, first patch introduce mipi_dsi_shutdown_peripheral_multi(), 
then second patch switch to multi
for wuxga_nt_panel_on() and wuxga_nt_panel_disable().

Thanks,
Neil



On Tue, Jan 6, 2026 at 1:51 PM <[email protected] 
<mailto:[email protected]>> wrote:

    Hi,

    On 11/27/25 17:08, Avinal Kumar wrote:
     > Changes the panasonic-vvx10f034n00 panel to multi
     > style functions for improved error handling.
     >
     > Signed-off-by: Avinal Kumar <[email protected] 
<mailto:[email protected]>>
     > ---
     > Here is the todo list for reference: 
https://www.kernel.org/doc/html/latest/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions
 
<https://www.kernel.org/doc/html/latest/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions>
     >
     > This is my first patch in Linux Kernel :)
     >
     >   drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 7 ++++++-
     >   1 file changed, 6 insertions(+), 1 deletion(-)
     >
     > diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c 
b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
     > index 3c3308fc55df..03c87c02fb57 100644
     > --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
     > +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
     > @@ -44,7 +44,12 @@ static inline struct wuxga_nt_panel 
*to_wuxga_nt_panel(struct drm_panel *panel)
     >
     >   static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt)
     >   {
     > -     return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi);
     > +     struct mipi_dsi_multi_context dsi_ctx = {
     > +             .dsi = wuxga_nt->dsi
     > +     };
     > +
     > +     mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
     > +     return dsi_ctx.accum_err;
     >   }
     >
     >   static int wuxga_nt_panel_disable(struct drm_panel *panel)

    Why didn't you also update wuxga_nt_panel_disable() ?

    Thanks,
    Neil


Reply via email to