Make sure to return an error in the event that we can't create our
properties.
Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support")
Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to
userspace")
Signed-off-by: Sean Anderson <[email protected]>
Reviewed-by: Anatoliy Klymenko <[email protected]>
Reviewed-by: Thomas Zimmermann <[email protected]>
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c
b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index 02f3a7d78cf8..816bea4ea986 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -175,9 +175,15 @@ static int zynqmp_dpsub_create_planes(struct zynqmp_dpsub
*dpsub)
drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs);
- drm_plane_create_zpos_immutable_property(plane, i);
- if (i == ZYNQMP_DPSUB_LAYER_GFX)
- drm_plane_create_alpha_property(plane);
+ ret = drm_plane_create_zpos_immutable_property(plane, i);
+ if (ret)
+ return ret;
+
+ if (i == ZYNQMP_DPSUB_LAYER_GFX) {
+ ret = drm_plane_create_alpha_property(plane);
+ if (ret)
+ return ret;
+ }
}
return 0;
--
2.35.1.1320.gc452695387.dirty
