Thanks for the feedback. I have regenerated and resent the patch as v3: https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u
---------- Forwarded message --------- 发件人： Mukesh Ojha <[email protected]> Date: 2026年1月13日周二 14:36 Subject: Re: [PATCH v2] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe To: Xingjing Deng <[email protected]> Cc: <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, Xingjing Deng <[email protected]>, <[email protected]> On Tue, Jan 13, 2026 at 10:38:39AM +0800, Xingjing Deng wrote: > In the SDSP probe path, qcom_scm_assign_mem() is used to assign the > reserved memory to the configured VMIDs, but its return value was not > checked. > > Fail the probe if the SCM call fails to avoid continuing with an > unexpected/incorrect memory permission configuration > > Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access to the > DSP") > Cc: [email protected] # 6.11-rc1 > Signed-off-by: Xingjing Deng <[email protected]> I don't see the lkml mailing list as part of this patch.. please use ./scripts/get_maintainer.pl to collect all the necessary mailing list and maintainers to be cc'd. > > v2 changes: > Add Fixes: and Cc: [email protected]. Changelog should go below ---. Also include the link to the v1 in it. > --- > drivers/misc/fastrpc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index fb3b54e05928..cbb12db110b3 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -2338,8 +2338,13 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device > *rpdev) > if (!err) { > src_perms = BIT(QCOM_SCM_VMID_HLOS); > > - qcom_scm_assign_mem(res.start, resource_size(&res), > &src_perms, > + err = qcom_scm_assign_mem(res.start, > resource_size(&res), &src_perms, > data->vmperms, data->vmcount); > + if (err) { > + dev_err(rdev, "Failed to assign memory phys > 0x%llx size 0x%llx err %d", > + res.start, resource_size(&res), err); > + goto err_free_data; > + } > } > > } > -- > 2.25.1 > -- -Mukesh Ojha
