Hi Marek,
On Mon, 26 Jan 2026 at 00:18, Marek Vasut <[email protected]> wrote:
> On 1/22/26 4:35 PM, Geert Uytterhoeven wrote:
> >> Can you please test this change and see if it fixes the problem ?
> >>
> >> The barrier should guarantee that the domain is settled and no more
> >> callbacks are still running.
> >
> > Thank you, that indeed fixes the issue!
> >
> > However, I am not so sure this barrier belongs in the .detach_dev()
> > callback. The documentation for almost all dev_pm_domain_{at,de}tach*()
> > functions states:
> >
> > * Callers must ensure proper synchronization of this function with
> > power
> > * management callbacks.
>
> Isn't cpg_mssr_detach_dev() the caller in this case ?
No, cpg_mssr_detach_dev() is merely the generic_pm_domain.detach_dev()
callback, which is called eventually from dev_pm_domain_detach().
End users like pvr_power_domains_{fini,init}(), and the helpers
dev_pm_domain_{at,de}tach_list() call dev_pm_domain_{at,de}tach*().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
