Hi Tomi,

Thank you for the patch.

On Mon, Dec 01, 2025 at 02:18:47PM +0200, Tomi Valkeinen wrote:
> Add X403, a 3 plane 10 bits per component non-subsampled YCbCr format.

This makes me wish for a X509 format, for maximum confusion :-)

> Reviewed-by: Dmitry Baryshkov <[email protected]>
> Reviewed-by: Vishal Sagar <[email protected]>
> Signed-off-by: Tomi Valkeinen <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>  drivers/gpu/drm/drm_fourcc.c  | 3 +++
>  include/uapi/drm/drm_fourcc.h | 9 +++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> index 0d222f6c1a30..ab643dedd6d4 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -391,6 +391,9 @@ const struct drm_format_info *__drm_format_info(u32 
> format)
>               { .format = DRM_FORMAT_Y10_P32,         .depth = 0,  
> .num_planes = 1,
>                 .char_per_block = { 4, 0, 0 }, .block_w = { 3, 0, 0 }, 
> .block_h = { 1, 0, 0 },
>                 .hsub = 1, .vsub = 1, .is_yuv = true },
> +             { .format = DRM_FORMAT_X403,            .depth = 0,  
> .num_planes = 3,
> +               .char_per_block = { 4, 4, 4 }, .block_w = { 3, 3, 3 }, 
> .block_h = { 1, 1, 1 },
> +               .hsub = 1, .vsub = 1, .is_yuv = true },
>       };
>  
>       unsigned int i;
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 0fd99ae32a06..abe6af8b5ac4 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -403,6 +403,15 @@ extern "C" {
>   */
>  #define DRM_FORMAT_Q401              fourcc_code('Q', '4', '0', '1')
>  
> +/*
> + * 3 plane non-subsampled (444) YCbCr
> + * 10 bpc, 30 bits per sample image data in a single contiguous buffer.
> + * index 0: Y plane,  [31:0] x:Y2:Y1:Y0    [2:10:10:10] little endian
> + * index 1: Cb plane, [31:0] x:Cb2:Cb1:Cb0 [2:10:10:10] little endian
> + * index 2: Cr plane, [31:0] x:Cr2:Cr1:Cr0 [2:10:10:10] little endian
> + */
> +#define DRM_FORMAT_X403              fourcc_code('X', '4', '0', '3')
> +
>  /*
>   * 3 plane YCbCr LSB aligned
>   * In order to use these formats in a similar fashion to MSB aligned ones
> 

-- 
Regards,

Laurent Pinchart

Reply via email to