Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command

[Mario Limonciello]

On 2/3/26 12:40 PM, Lizhi Hou wrote:

The driver currently returns an incorrect error code when a chain command
fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
failed chain commands.

Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
Signed-off-by: Lizhi Hou <lizhi....@amd.com>

Reviewed-by: Mario Limonciello (AMD) <supe...@kernel.org>

---
  drivers/accel/amdxdna/aie2_ctx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
index ad5b5cd0bc81..fe8f9783a73c 100644
--- a/drivers/accel/amdxdna/aie2_ctx.c
+++ b/drivers/accel/amdxdna/aie2_ctx.c
@@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem 
*data, size_t size)
                ret = -EINVAL;
                goto out;
        }
-       amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
+       amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);

if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {

                struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, 
NULL);