Hello,
At 2026-02-04 15:53:19, "Chen Ni" <[email protected]> wrote:
>Return the value of devm_drm_bridge_add() in order to propagate the
>error properly, if it fails due to resource allocation failure or bridge
>registration failure.
>
>This ensures that the bind function fails safely rather than proceeding
>with a potentially incomplete bridge setup.
>
>Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before
>attaching")
>Signed-off-by: Chen Ni <[email protected]>
>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 432342452484..b0007805f283 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -2049,7 +2049,9 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct
>drm_encoder *encoder,
> bridge->type = DRM_MODE_CONNECTOR_DisplayPort;
> bridge->ycbcr_420_allowed = true;
>
>- devm_drm_bridge_add(dev, bridge);
>+ ret = devm_drm_bridge_add(dev, bridge);
>+ if (ret)
>+ return dev_err_ptr_probe(dev, ret, "Failed to add bridge\n");
The return value of this funciont is struct dw_dp*, so you should
return ERR_PTR(ret) here.>
> dp->aux.dev = dev;
> dp->aux.drm_dev = encoder->dev;
>--
>2.25.1
