Return devm_drm_bridge_add() in order to transfer the error if it fails.

This ensures that the probe function fails safely rather than proceeding
with a potentially incomplete bridge setup.

Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
Signed-off-by: Chen Ni <[email protected]>
---
 drivers/gpu/drm/bridge/waveshare-dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c 
b/drivers/gpu/drm/bridge/waveshare-dsi.c
index 43f4e7412d72..e25b139b4a41 100644
--- a/drivers/gpu/drm/bridge/waveshare-dsi.c
+++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
@@ -177,9 +177,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
 
        ws->bridge.type = DRM_MODE_CONNECTOR_DPI;
        ws->bridge.of_node = dev->of_node;
-       devm_drm_bridge_add(dev, &ws->bridge);
 
-       return 0;
+       return devm_drm_bridge_add(dev, &ws->bridge);
 }
 
 static const struct of_device_id ws_bridge_of_ids[] = {
-- 
2.25.1

Reply via email to