Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195

[AngeloGioacchino Del Regno]

Il 23/12/25 20:44, Nícolas F. R. A. Prado ha scritto:

MT8195's OVL hardware supports per-plane color operations. Enable
support for it in the driver.

Signed-off-by: Nícolas F. R. A. Prado <nfrapr...@collabora.com>

Agreed, but you're enabling something that doesn't exist.
Please move this commit at the end, so that you enable it after it's all
implemented.

Cheers,
Angelo

---
  drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c 
b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 46238c21b0ac..cfc6a3154f73 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -738,6 +738,7 @@ static const struct mtk_disp_ovl_data 
mt8195_ovl_driver_data = {
        .fmt_rgb565_is_0 = true,
        .smi_id_en = true,
        .supports_afbc = true,
+       .supports_plane_colorops = true,
        .blend_modes = BIT(DRM_MODE_BLEND_PREMULTI) |
                       BIT(DRM_MODE_BLEND_COVERAGE) |
                       BIT(DRM_MODE_BLEND_PIXEL_NONE),