Hi Maira, Thanks for the review!
On Sat, Feb 07, 2026 at 05:34:58PM -0300, Maíra Canal wrote:
> > @@ -716,13 +725,28 @@ static void vc4_load_tracker_destroy_state(struct
> > drm_private_obj *obj,
> > load_state = to_vc4_load_tracker_state(state);
> > kfree(load_state);
> > }
> > +static struct drm_private_state *
> > +vc4_load_tracker_create_state(struct drm_private_obj *obj)
> > +{
> > + struct vc4_load_tracker_state *load_state;
> > +
> > + load_state = kzalloc(sizeof(*load_state), GFP_KERNEL);
> > + if (!load_state)
> > + return ERR_PTR(-ENOMEM);
> > +
> > + __drm_atomic_helper_private_obj_create_state(obj, &load_state->base);
> > +
> > + return &load_state->base;
> > +}
> > +
> > static const struct drm_private_state_funcs vc4_load_tracker_state_funcs
> > = {
> > .atomic_duplicate_state = vc4_load_tracker_duplicate_state,
> > .atomic_destroy_state = vc4_load_tracker_destroy_state,
> > + .atomic_create_state = vc4_load_tracker_create_state,
>
> Minor nit: just to keep things consistent, could you move this hook to
> the first line?
Good catch, I've fixed it up while applying.
Thanks!
Maxime
signature.asc
Description: PGP signature
