The function dw_dp_video_need_vsc_sdp() returns a bool type but in a
error path -EINVAL is returned. This allows the possibility of this
function returning true when dw_dp_get_bridge_state() fails.

Signed-off-by: Ethan Tidmore <[email protected]>
---
 drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c 
b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 432342452..a80d955f2 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
        state = dw_dp_get_bridge_state(dp);
        if (!state)
-               return -EINVAL;
+               return false;
 
        if (!link->vsc_sdp_supported)
                return false;
-- 
2.53.0

Reply via email to