On 2/11/26 3:05 PM, Dave Airlie wrote:
> On Thu, 12 Feb 2026 at 06:02, Chris Mason <[email protected]> wrote:
>>
[ ... ]
>>> This is also just an experiment to see what might stick, it might
>>> disappear at any time, and it probably needs a lot of tuning.
>>
>> The output is pretty different from netdev/bpf:
>>
>> https://lore.kernel.org/bpf/?q=AI+reviewed+your+patch
>>
>> Which might be what you want so it's fine of course. But it looks like
>> it didn't actually go through the report generation from the review
>> prompts, so I'm worried it didn't use the rest of the prompts either.
>>
>> My stuff should be creating a review-inline.txt which is the lkml
>> formatted review.
>>
>> I'm happy to try things out here if it'll help.
>
> My plan over the next few days is to refine the code to make sure it's
> doing this, my prompt asks it to load the patch and the kernel
> prompts, then do a review across the series and individual patches,
>
> I'm guessing some of the results aren't making it back out the other side.
I had to change the prompts a bit, I think my original instructions were:
"read prompt xyz and patch abc, review the patch"
But sometimes claude would read the prompt and the patch and then follow
it's own review protocol instead of mine. The current /kreview slash
command is a lot more reliable:
Read the prompt <path to prompts dir>/kernel/review-core.md
If a git range is provided, it's meant for the false-positive-guide.md
section
Using the prompt, do a deep dive regression analysis of the top commit,
or the provided patch/commit
-chris
