On Sat, 26 Oct 2024 14:29:27 +0200, Krzysztof Kozlowski wrote: > On Fri, Oct 25, 2024 at 04:11:28PM +0200, Rouven Czerwinski wrote: > > A nit, subject: drop second/last, redundant "YAML schema for". The > "dt-bindings" prefix is already stating that these are bindings in > schema and YAML. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Ack. I'll change the subject to "dt-bindings: display: panel: add LXD M9189A" in v4. > > > +++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml > > @@ -0,0 +1,68 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LXD M9189A DSI Display Panel > > + > > +maintainers: > > + - Rouven Czerwinski <[email protected]> > > + > > +properties: > > + compatible: > > + const: lxd,m9189a > > + > > + reg: > > + maxItems: 1 > > + > > + standby-gpios: > > + description: GPIO used for the standby pin > > + maxItems: 1 > > + > > + reset-gpios: > > + description: GPIO used for the reset pin > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Power regulator > > + > > + backlight: > > + description: Backlight used by the panel > > + $ref: /schemas/types.yaml#/definitions/phandle > > + > > + port: true > > This misses it's definition. You should reference proper panel schema in > top-level. Fixed in v3 by referring to panel-common.yaml as base. > > Best regards, > Krzysztof >
