Re: [PATCH] drm/tiny: sharp-memory: fix pointer error dereference

[Thomas Zimmermann]

Am 16.02.26 um 05:04 schrieb Ethan Tidmore:

The function devm_drm_dev_alloc() returns a pointer error upon failure
not NULL. Change null check to pointer error check.

Detected by Smatch:
drivers/gpu/drm/tiny/sharp-memory.c:549 sharp_memory_probe() error:
'smd' dereferencing possible ERR_PTR()

Fixes: b8f9f21716fec ("drm/tiny: Add driver for Sharp Memory LCD")
Signed-off-by: Ethan Tidmore <ethantidmor...@gmail.com>

Reviewed-by: Thomas Zimmermann <tzimmerm...@suse.de>

Thanks for the fix.

---
  drivers/gpu/drm/tiny/sharp-memory.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tiny/sharp-memory.c 
b/drivers/gpu/drm/tiny/sharp-memory.c
index 64272cd0f6e2..cbf69460ebf3 100644
--- a/drivers/gpu/drm/tiny/sharp-memory.c
+++ b/drivers/gpu/drm/tiny/sharp-memory.c
@@ -541,8 +541,8 @@ static int sharp_memory_probe(struct spi_device *spi)

smd = devm_drm_dev_alloc(dev, &sharp_memory_drm_driver,

                                 struct sharp_memory_device, drm);
-       if (!smd)
-               return -ENOMEM;
+       if (IS_ERR(smd))
+               return PTR_ERR(smd);

spi_set_drvdata(spi, smd);

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)