> -----Original Message-----
> From: Borah, Chaitanya Kumar <[email protected]>
> Sent: Wednesday, February 18, 2026 12:27 PM
> To: [email protected]; [email protected]; intel-
> [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Shankar, Uma <[email protected]>; [email protected];
> [email protected]; Nikula, Jani <[email protected]>;
> [email protected]; [email protected]; Borah, Chaitanya Kumar
> <[email protected]>
> Subject: [PATCH 1/2] drm/colorop: Preserve bypass value in duplicate_state()
>
> __drm_atomic_helper_colorop_duplicate_state() unconditionally sets state-
> >bypass = true after copying the existing state.
>
> This override causes the new atomic state to no longer reflect the currently
> committed hardware state. Since the bypass property directly controls whether
> the
> colorop is active in hardware, resetting it to true can inadvertently disable
> an
> active colorop during a subsequent commit, particularly for internal driver
> commits
> where userspace does not touch the property.
>
> Drop the unconditional assignment and preserve the duplicated bypass value.
Looks Good to me.
Reviewed-by: Uma Shankar <[email protected]>
> Fixes: 8c5ea1745f4c ("drm/colorop: Add BYPASS property")
> Cc: <[email protected]> #v6.19+
> Signed-off-by: Chaitanya Kumar Borah <[email protected]>
> ---
> drivers/gpu/drm/drm_colorop.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
> index
> aa19de769eb2..5037efcc3497 100644
> --- a/drivers/gpu/drm/drm_colorop.c
> +++ b/drivers/gpu/drm/drm_colorop.c
> @@ -466,8 +466,6 @@ static void
> __drm_atomic_helper_colorop_duplicate_state(struct drm_colorop *colo
>
> if (state->data)
> drm_property_blob_get(state->data);
> -
> - state->bypass = true;
> }
>
> struct drm_colorop_state *
> --
> 2.25.1
