> > The mt8167 DSI controller is fully compatible with the one found in > > mt2701. Device tree documentation is already present upstream. > > If mt8167 DSI is fully compatible with mt2701 DSI, I think the binding > document and device tree should be modified. > In device tree, > > compatible = "mediatek,mt8167-dsi", "mediatek,mt2701-dsi"; > > And this patch is not necessary.
Hi, if I understand your review correctly that's what v2 [1] of this patch did, but the change was rejected during review. As far as I can see there is no win-win solution here. This tricky situation derives from the fact that in last year's submissions the change was only partially merged - the bindings went upstream while the driver did not, and now we have to work around this. In v3 I tried to address the issue by actually implementing what the binding document says. I'll be happy to resubmit v4 but I need to know what's the consensus here. Thanks! [1] https://patchwork.kernel.org/project/linux-mediatek/patch/ff920a7cc94f2b0c03d4bb55142030fded30d07c.1771258407.git.l.scor...@gmail.com/ > > > > Signed-off-by: Luca Leonardo Scorcia <[email protected]> > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index af4871de9e4c..ad10e86b161d 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -1301,6 +1301,7 @@ static const struct mtk_dsi_driver_data > > mt8188_dsi_driver_data = { > > > > static const struct of_device_id mtk_dsi_of_match[] = { > > { .compatible = "mediatek,mt2701-dsi", .data = > > &mt2701_dsi_driver_data }, > > + { .compatible = "mediatek,mt8167-dsi", .data = > > &mt2701_dsi_driver_data }, > > { .compatible = "mediatek,mt8173-dsi", .data = > > &mt8173_dsi_driver_data }, > > { .compatible = "mediatek,mt8183-dsi", .data = > > &mt8183_dsi_driver_data }, > > { .compatible = "mediatek,mt8186-dsi", .data = > > &mt8186_dsi_driver_data }, > > -- > > 2.43.0 > > > > -- Luca Leonardo Scorcia [email protected]
