On Wed, 25 Feb 2026 22:41:49 +0900
Eliot Courtney <[email protected]> wrote:
> Add sync and async command queue API and the type infrastructure to
> know what reply is expected from each `CommandToGsp`.
>
snip
> + loop {
> + match self.receive_msg::<M::Reply>(Delta::from_secs(10))
It turns out here the timeout is changed to 10s from 5s which was used
in other places. Any problem you encountered during the debugging?
Z.
> {
> + Ok(reply) => break Ok(reply),
> + Err(ERANGE) => continue,
> + Err(e) => break Err(e),
> + }
> + }
> + }
> +
> + /// Sends `command` to the GSP without waiting for a reply.
> + ///
> + /// # Errors
> + ///
> + /// - `ETIMEDOUT` if space does not become available within the
> timeout.
> + /// - `EIO` if the variable payload requested by the command has
> not been entirely
> + /// written to by its [`CommandToGsp::init_variable_payload`]
> method.
> + ///
> + /// Error codes returned by the command initializers are
> propagated as-is.
> + pub(crate) fn send_async_command<M>(&mut self, bar: &Bar0,
> command: M) -> Result
> + where
> + M: CommandToGsp<Reply = NoReply>,
> + Error: From<M::InitError>,
> + {
> + self.send_command(bar, command)
> + }
> +
> /// Wait for a message to become available on the message queue.
> ///
> /// This works purely at the transport layer and does not
> interpret or validate the message diff --git
> a/drivers/gpu/nova-core/gsp/commands.rs
> b/drivers/gpu/nova-core/gsp/commands.rs index
> 1683ebb4c685..b42e32dcc55c 100644 ---
> a/drivers/gpu/nova-core/gsp/commands.rs +++
> b/drivers/gpu/nova-core/gsp/commands.rs @@ -26,7 +26,8 @@
> command_size, Cmdq,
> CommandToGsp,
> - MessageFromGsp, //
> + MessageFromGsp,
> + NoReply, //
> },
> fw::{
> commands::*,
> @@ -53,6 +54,7 @@ pub(crate) fn new(pdev: &'a
> pci::Device<device::Bound>) -> Self { impl<'a> CommandToGsp for
> SetSystemInfo<'a> { const FUNCTION: MsgFunction =
> MsgFunction::GspSetSystemInfo; type Command = GspSetSystemInfo;
> + type Reply = NoReply;
> type InitError = Error;
>
> fn init(&self) -> impl Init<Self::Command, Self::InitError> {
> @@ -104,6 +106,7 @@ pub(crate) fn new() -> Self {
> impl CommandToGsp for SetRegistry {
> const FUNCTION: MsgFunction = MsgFunction::SetRegistry;
> type Command = PackedRegistryTable;
> + type Reply = NoReply;
> type InitError = Infallible;
>
> fn init(&self) -> impl Init<Self::Command, Self::InitError> {
> @@ -183,6 +186,7 @@ pub(crate) fn wait_gsp_init_done(cmdq: &mut Cmdq)
> -> Result { impl CommandToGsp for GetGspStaticInfo {
> const FUNCTION: MsgFunction = MsgFunction::GetGspStaticInfo;
> type Command = GspStaticConfigInfo;
> + type Reply = GetGspStaticInfoReply;
> type InitError = Infallible;
>
> fn init(&self) -> impl Init<Self::Command, Self::InitError> {
> @@ -236,15 +240,7 @@ pub(crate) fn gpu_name(&self) ->
> core::result::Result<&str, GpuNameError> {
> /// Send the [`GetGspInfo`] command and awaits for its reply.
> pub(crate) fn get_gsp_info(cmdq: &mut Cmdq, bar: &Bar0) ->
> Result<GetGspStaticInfoReply> {
> - cmdq.send_command(bar, GetGspStaticInfo)?;
> -
> - loop {
> - match
> cmdq.receive_msg::<GetGspStaticInfoReply>(Delta::from_secs(5)) {
> - Ok(info) => return Ok(info),
> - Err(ERANGE) => continue,
> - Err(e) => return Err(e),
> - }
> - }
> + cmdq.send_sync_command(bar, GetGspStaticInfo)
> }
>
> /// The `ContinuationRecord` command.
> @@ -262,6 +258,7 @@ pub(crate) fn new(data: &'a [u8]) -> Self {
> impl<'a> CommandToGsp for ContinuationRecord<'a> {
> const FUNCTION: MsgFunction = MsgFunction::ContinuationRecord;
> type Command = ();
> + type Reply = NoReply;
> type InitError = Infallible;
>
> fn init(&self) -> impl Init<Self::Command, Self::InitError> {
> @@ -354,6 +351,7 @@ pub(crate) enum SplitCommand<'a, C: CommandToGsp>
> { impl<'a, C: CommandToGsp> CommandToGsp for SplitCommand<'a, C> {
> const FUNCTION: MsgFunction = C::FUNCTION;
> type Command = C::Command;
> + type Reply = C::Reply;
> type InitError = C::InitError;
>
> fn init(&self) -> impl Init<Self::Command, Self::InitError> {
> @@ -410,6 +408,7 @@ fn new(len: usize) -> Result<Self> {
> impl CommandToGsp for TestPayload {
> const FUNCTION: MsgFunction = MsgFunction::Nop;
> type Command = ();
> + type Reply = NoReply;
> type InitError = Infallible;
>
> fn init(&self) -> impl Init<Self::Command, Self::InitError> {
>
