On 2/24/26 9:24 AM, Thomas Zimmermann wrote: > Replace simple-display helpers with regular atomic helpers. Store the > pipeline elements in struct st7586_device and initialize them as part > of probing the device. Use mipi-dbi's existing helpers and initializer > macros where possible. > > Effectively open-codes the modesetting code in the initializer helpers > of mipi-dbi and simple-display. St7586 requires custom helpers for > various pipeline elements, and non-freeing cleanup of the pipeline. > > Signed-off-by: Thomas Zimmermann <[email protected]> > ---
This results in a couple of unused variable warnings, but otherwise seems to still work. Tested-by: David Lechner <[email protected]> /home/david/work/bl/linux/drivers/gpu/drm/sitronix/st7586.c: In function ‘st7586_pipe_enable’: /home/david/work/bl/linux/drivers/gpu/drm/sitronix/st7586.c:180:25: warning: unused variable ‘rect’ [-Wunused-variable] 180 | struct drm_rect rect = { | ^~~~ /home/david/work/bl/linux/drivers/gpu/drm/sitronix/st7586.c:177:40: warning: unused variable ‘shadow_plane_state’ [-Wunused-variable] 177 | struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(plane_state); | ^~~~~~~~~~~~~~~~~~
