On Mon Mar 2, 2026 at 1:54 PM JST, Eliot Courtney wrote: > On Sun Mar 1, 2026 at 11:03 PM JST, Alexandre Courbot wrote: >> The current `FalconLoadParams` and `FalconLoadTarget` types are fit for >> DMA loading, but not so much for PIO loading which will require its own >> types. Start by renaming them to something that indicates that they are >> indeed DMA-related. >> >> Signed-off-by: Alexandre Courbot <[email protected]> >> --- >> diff --git a/drivers/gpu/nova-core/firmware/booter.rs >> b/drivers/gpu/nova-core/firmware/booter.rs >> index 2b7166eaf283..d569151982d1 100644 >> --- a/drivers/gpu/nova-core/firmware/booter.rs >> +++ b/drivers/gpu/nova-core/firmware/booter.rs >> @@ -19,8 +19,8 @@ >> Falcon, >> FalconBromParams, >> FalconFirmware, >> - FalconLoadParams, >> - FalconLoadTarget, // >> + FalconDmaLoadable, >> + FalconDmaLoadTarget, // >> }, > > I think here but also other files in this patch are not rustfmt'd (e.g. > import ordering here).
Oopsie, you're right. Sorry about that, that's what happens when I don't run my checklist script. And it's even worse, the build breaks in the middle of the series. I'll respin and think of some penance to atone for my carelessness.
