From: Frank Li (AI-BOT) <[email protected]> AI bot review and may be useless.
This is a device tree bindings patch, not kernel C code. The YAML schema additions look structurally sound. A few observations: > + dpi-bridge: > + type: object > + additionalProperties: false > + > + properties: > + compatible: > + enum: > + - nxp,imx91-pdfc > + - nxp,imx93-pdfc The compatible strings should be documented in a separate vendor prefix file (nxp.yaml) if not already present. Verify they exist in Documentation/devicetree/bindings/vendor-prefixes.yaml. > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input port node to receive pixel data. > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false The port@0 and port@1 both reference graph.yaml but use slightly different schemas ($defs/port-base vs #/properties/port). Ensure this inconsistency is intentional; typically both would use the same reference unless port@1 has special constraints. > + properties: > + bus-width: > + enum: [ 16, 18, 24 ] Line length is acceptable. The bus-width enum values are clear. > + This property must be set to 18 to cut only the LSBs > + instead of the MSBs in case a 24-bit RGB888 display is > + connected and only the lower 18-bit data lanes are > muxed > + to the parallel-output pads. Documentation is thorough and explains the non-obvious behavior (LSB vs MSB truncation). Good. Overall: schema is well-structured, example is complete, and documentation is clear. No blocking issues detected.
