Update subject line to match history: PCI: Add missing headers transitively included by <linux/phy/phy.h>
On Wed, Mar 04, 2026 at 07:57:15PM +0200, Vladimir Oltean wrote: > The tegra as well as a few dwc PCI controller drivers uses PM runtime > operations without including the required <linux/pm_runtime.h> header. > > Similarly, pcie-rockchip-host, pcie-starfive as well as a few dwc PCI > controllers use the regulator consumer API without including > <linux/regulator/consumer.h>. > > It seems these function prototypes were indirectly provided by > <linux/phy/phy.h>, mostly by mistake (none of the functions it exports > need it). > > Before the PHY header can drop the unnecessary includes, make sure the > PCI controller drivers include what they use. > > Signed-off-by: Vladimir Oltean <[email protected]> With the subject line update: Acked-by: Bjorn Helgaas <[email protected]> > --- > Cc: Lorenzo Pieralisi <[email protected]> > Cc: "Krzysztof Wilczyński" <[email protected]> > Cc: Manivannan Sadhasivam <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Bjorn Helgaas <[email protected]> > Cc: Heiko Stuebner <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Yixun Lan <[email protected]> > Cc: Thierry Reding <[email protected]> > Cc: Jonathan Hunter <[email protected]> > Cc: Shawn Lin <[email protected]> > Cc: Kevin Xie <[email protected]> > --- > drivers/pci/controller/dwc/pci-keystone.c | 1 + > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 1 + > drivers/pci/controller/dwc/pcie-histb.c | 1 + > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + > drivers/pci/controller/dwc/pcie-spacemit-k1.c | 2 ++ > drivers/pci/controller/dwc/pcie-tegra194.c | 1 + > drivers/pci/controller/pci-tegra.c | 1 + > drivers/pci/controller/pcie-rockchip-host.c | 1 + > drivers/pci/controller/plda/pcie-starfive.c | 1 + > 9 files changed, 10 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c > b/drivers/pci/controller/dwc/pci-keystone.c > index 20fa4dadb82a..642e4c45eefc 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -24,6 +24,7 @@ > #include <linux/of_pci.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > #include <linux/regmap.h> > #include <linux/resource.h> > #include <linux/signal.h> > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index 5b17da63151d..e0079ec108ab 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -21,6 +21,7 @@ > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > #include <linux/regmap.h> > +#include <linux/regulator/consumer.h> > #include <linux/reset.h> > > #include "../../pci.h" > diff --git a/drivers/pci/controller/dwc/pcie-histb.c > b/drivers/pci/controller/dwc/pcie-histb.c > index a52071589377..432a54c5bfce 100644 > --- a/drivers/pci/controller/dwc/pcie-histb.c > +++ b/drivers/pci/controller/dwc/pcie-histb.c > @@ -18,6 +18,7 @@ > #include <linux/pci.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/regulator/consumer.h> > #include <linux/resource.h> > #include <linux/reset.h> > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c > b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index 18460f01b2c6..e417122da51d 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -19,6 +19,7 @@ > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > #include <linux/pm_domain.h> > +#include <linux/pm_runtime.h> > #include <linux/regmap.h> > #include <linux/reset.h> > #include <linux/module.h> > diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c > b/drivers/pci/controller/dwc/pcie-spacemit-k1.c > index be20a520255b..dbec159fd458 100644 > --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c > +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c > @@ -15,7 +15,9 @@ > #include <linux/mod_devicetable.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > #include <linux/regmap.h> > +#include <linux/regulator/consumer.h> > #include <linux/reset.h> > #include <linux/types.h> > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c > b/drivers/pci/controller/dwc/pcie-tegra194.c > index 06571d806ab3..3378a89580ab 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -27,6 +27,7 @@ > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/random.h> > +#include <linux/regulator/consumer.h> > #include <linux/reset.h> > #include <linux/resource.h> > #include <linux/types.h> > diff --git a/drivers/pci/controller/pci-tegra.c > b/drivers/pci/controller/pci-tegra.c > index 512309763d1f..a2c1662b6e81 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -36,6 +36,7 @@ > #include <linux/phy/phy.h> > #include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > #include <linux/reset.h> > #include <linux/sizes.h> > #include <linux/slab.h> > diff --git a/drivers/pci/controller/pcie-rockchip-host.c > b/drivers/pci/controller/pcie-rockchip-host.c > index ee1822ca01db..46adb4582fcc 100644 > --- a/drivers/pci/controller/pcie-rockchip-host.c > +++ b/drivers/pci/controller/pcie-rockchip-host.c > @@ -24,6 +24,7 @@ > #include <linux/of_pci.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/regulator/consumer.h> > > #include "../pci.h" > #include "pcie-rockchip.h" > diff --git a/drivers/pci/controller/plda/pcie-starfive.c > b/drivers/pci/controller/plda/pcie-starfive.c > index 298036c3e7f9..22344cca167b 100644 > --- a/drivers/pci/controller/plda/pcie-starfive.c > +++ b/drivers/pci/controller/plda/pcie-starfive.c > @@ -21,6 +21,7 @@ > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/regmap.h> > +#include <linux/regulator/consumer.h> > #include <linux/reset.h> > #include "../../pci.h" > > -- > 2.43.0 >
