On Thu, 5 Mar 2026 11:07:23 +0000 Akash Goel <[email protected]> wrote:
> This commit corrects the order of arguments passed to panthor_gem_sync() > function, called when the SYNC_WAIT condition has to be evaluated for a > blocked GPU queue. > > Fixes: cd2c9c3015e6 (drm/panthor: Add flag to map GEM object Write-Back > Cacheable) > Signed-off-by: Akash Goel <[email protected]> Oops, good catch! Reviewed-by: Boris Brezillon <[email protected]> > --- > drivers/gpu/drm/panthor/panthor_sched.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c > b/drivers/gpu/drm/panthor/panthor_sched.c > index bd703a2904a1..a70f1db0764e 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group > *group, struct panthor_queue > > out_sync: > /* Make sure the CPU caches are invalidated before the seqno is read. > - * drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check > + * panthor_gem_sync() is a NOP if map_wc=true, so no need to check > * it here. > */ > - panthor_gem_sync(&bo->base.base, queue->syncwait.offset, > + panthor_gem_sync(&bo->base.base, > + DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE, > + queue->syncwait.offset, > queue->syncwait.sync64 ? > sizeof(struct panthor_syncobj_64b) : > - sizeof(struct panthor_syncobj_32b), > - DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE); > + sizeof(struct panthor_syncobj_32b)); > > return queue->syncwait.kmap + queue->syncwait.offset; >
