On Thu, Mar 5, 2026 at 12:37 PM Maarten Lankhorst <[email protected]> wrote: > > This reverts commit 2e3649e237237258a08d75afef96648dd2b379f7. > > The problem occurs when userspace is compiled against new headers > with new members, but don't correctly initialise those new members. > > This is not a kernel problem, and should be fixed in userspace by > correctly zero'ing all members.
I don't mind it being reverted since userspace rust code is not affected by this failure mode. However, if you're committed to the idea that this is a userspace issue, then I think the correct solution would be to instead apply the patch you suggested. It clarifies the intention of the code in my opinion. > > Cc: Rob Clark <[email protected]> > Cc: Julian Orth <[email protected]> > Cc: Christian König <[email protected]> > Cc: Michel Dänzer <[email protected]> > Signed-off-by: Maarten Lankhorst <[email protected]> > --- > drivers/gpu/drm/drm_syncobj.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c > index 49eccb43ce63d..250734dee928e 100644 > --- a/drivers/gpu/drm/drm_syncobj.c > +++ b/drivers/gpu/drm/drm_syncobj.c > @@ -875,7 +875,7 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, > void *data, > return drm_syncobj_export_sync_file(file_private, > args->handle, > point, &args->fd); > > - if (point) > + if (args->point) > return -EINVAL; > > return drm_syncobj_handle_to_fd(file_private, args->handle, > @@ -909,7 +909,7 @@ drm_syncobj_fd_to_handle_ioctl(struct drm_device *dev, > void *data, > args->handle, > point); > > - if (point) > + if (args->point) > return -EINVAL; > > return drm_syncobj_fd_to_handle(file_private, args->fd, > -- > 2.51.0 >
