Hi
Am 13.03.26 um 07:44 schrieb Biju Das:
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Biju Das
Sent: 12 March 2026 17:47
To: Tommaso Merciai <[email protected]>; Thomas Zimmermann
<[email protected]>
Cc: [email protected]; [email protected];
[email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]; [email protected];
[email protected]
Subject: RE: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in
mmap
Hi Tommaso,
-----Original Message-----
From: Tommaso Merciai <[email protected]>
Sent: 12 March 2026 17:37
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty
status in mmap
Hi Thomas,
Thanks for your patch.
I'm working on DSI support for RZ/G3E from this morning rebasing on
top of next-20260311 I'm seeing that weston hang on my side:
Reverting this patch fix the issue.
(git revert 28e3918179aa)
I'm wondering if anyone encountered this issue?
Thanks in advance.
I am also seeing same issue on RZ/G3L with weston.
Just add I am using mesa with panfrost(Mali-G31) on RZ/G3L.
I ran the tests with bochs. I don't have panfrost hardware to test
with, but nothing in the driver sticks out as problematic. Only the gem
open/close logic looks a bit awkward. The mmap code appears to be identical.
Disabling Mali-G31 renders weston desktop during boot.
Looks like this patch is creating some hang in panfrost driver
during weston launch.
Does either of you see any warnings in the kernel messages?
Cheers,
[...]
+ if (ret == VM_FAULT_NOPAGE)
+ folio_mark_accessed(folio);
+
[...]
[...]
+ if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
+ return VM_FAULT_SIGBUS;
[...]
+ file_update_time(vma->vm_file);
[...]
+
+ folio_mark_dirty(page_folio(shmem->pages[page_offset]));
Out-commenting either of these should work. Could you please go through
them one by one and test if out-commenting either makes a difference?
Best regards
Thomas
+
+ return 0;
+}
+
const struct vm_operations_struct drm_gem_shmem_vm_ops = {
.fault = drm_gem_shmem_fault,
.open = drm_gem_shmem_vm_open,
.close = drm_gem_shmem_vm_close,
+ .pfn_mkwrite = drm_gem_shmem_pfn_mkwrite,
};
EXPORT_SYMBOL_GPL(drm_gem_shmem_vm_ops);
--
2.52.0
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
