On 3/11/26 5:10 AM, Thomas Zimmermann wrote:
> Replace simple-display helpers with regular atomic helpers. Store the
> pipeline elements in struct ili9225_device and initialize them as part
> of probing the device. Use mipi-dbi's existing helpers and initializer
> macros where possible.
>
> Effectively open-codes the modesetting code in the initializer helpers
> of mipi-dbi and simple-display. Ili9225 requires custom helpers for
> various pipeline elements, and non-freeing cleanup of the pipeline.
>
...
> @@ -373,19 +432,22 @@ MODULE_DEVICE_TABLE(spi, ili9225_id);
> static int ili9225_probe(struct spi_device *spi)
> {
> struct device *dev = &spi->dev;
> + struct ili9225_device *ili9225;
> struct mipi_dbi_dev *dbidev;
> struct drm_device *drm;
> struct mipi_dbi *dbi;
> struct gpio_desc *rs;
> + struct drm_plane *plane;
> + struct drm_crtc *crtc;
> + struct drm_encoder *encoder;
> + struct drm_connector *connector;
> u32 rotation = 0;
> int ret;
>
> - dbidev = devm_drm_dev_alloc(dev, &ili9225_driver,
> - struct mipi_dbi_dev, drm);
> - if (IS_ERR(dbidev))
> - return PTR_ERR(dbidev);
> -
> - dbi = &dbidev->dbi;
Same as previous patch, removing this line is problematic.
And the next two ili9xxx patches as well.
