Hi
Am 24.02.26 um 17:10 schrieb Maxime Ripard:
Hi,
This series started from my work on the hardware state readout[1], and
was suggested by Dmitry[2].
This series deal with the fact that drm_private_obj (and thus bridges)
are not initialized using the same pattern than any other object. This
series solves that inconsistency by aligning it to what we're doing for
all the other objects.
This was tested on a TI SK-AM62, with three bridges.
Let me know what you think,
Maxime
1:
https://lore.kernel.org/dri-devel/[email protected]/
2:
https://lore.kernel.org/dri-devel/zvqtehg66dbrrdmik6ylo2kdk74umfzo5hbfkizwsb352nlyqv@jgouvmbfwa4x/
Signed-off-by: Maxime Ripard <[email protected]>
---
Changes in v5:
- Rebase to drm-misc-next
- Link to v4:
https://lore.kernel.org/r/[email protected]
Changes in v4:
- Fix a circular dependencies between modules by calling
__drm_atomic_helper_private_obj_create_state from
__drm_atomic_helper_bridge_reset instead of
drm_bridge_atomic_create_priv_state()
- Link to v3:
https://lore.kernel.org/r/[email protected]
Changes in v3:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v2:
https://lore.kernel.org/r/[email protected]
Changes in v2:
- Switch to a new hook instead of reset since some drm_private_objs want
to persist across suspends
- Drop the call to drm_private_obj_funcs.reset in
drm_mode_config_reset()
- Link to v1:
https://lore.kernel.org/r/[email protected]
---
Maxime Ripard (4):
drm/amdgpu: Switch private_obj initialization to atomic_create_state
drm/omapdrm: Switch private_obj initialization to atomic_create_state
drm/tegra: Switch private_obj initialization to atomic_create_state
drm/atomic: Remove state argument to drm_atomic_private_obj_init
Nice cleanup. For the whole series:
Reviewed-by: Thomas Zimmermann <[email protected]>
Best regards
Thomas
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 51 ++++++++++++----------
.../drm/arm/display/komeda/komeda_private_obj.c | 16 +++----
drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
drivers/gpu/drm/display/drm_dp_tunnel.c | 2 +-
drivers/gpu/drm/drm_atomic.c | 22 +++-------
drivers/gpu/drm/drm_bridge.c | 1 -
drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +-
drivers/gpu/drm/ingenic/ingenic-ipu.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 -
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 1 -
drivers/gpu/drm/omapdrm/omap_drv.c | 22 +++++++---
drivers/gpu/drm/tegra/hub.c | 22 +++++++---
drivers/gpu/drm/vc4/vc4_kms.c | 4 +-
include/drm/drm_atomic.h | 1 -
14 files changed, 76 insertions(+), 72 deletions(-)
---
base-commit: 196b2b95fec447c2c4460f753b277d840633fbef
change-id: 20251008-drm-private-obj-reset-ae1e2741027a
Best regards,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
