On 30/03/2026 10:33, Maíra Canal wrote:
drm_connector_attach_hdr_output_metadata_property() always returns zero,
since drm_object_attach_property() returns void. No caller checks the
return value, so change the return type to void.
Also fix a typo in the kerneldoc ("HDR_OUTPUT_METADA" -> "HDR_OUTPUT_METADATA").
Reviewed-by: Melissa Wen <[email protected]>
Signed-off-by: Maíra Canal <[email protected]> --- drivers/gpu/drm/drm_connector.c | 9 ++------- include/drm/drm_connector.h | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 47dc53c4a738..3fa4d2082cd7 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2867,23 +2867,18 @@ int drm_connector_attach_max_bpc_property(struct drm_connector *connector, EXPORT_SYMBOL(drm_connector_attach_max_bpc_property);/**- * drm_connector_attach_hdr_output_metadata_property - attach "HDR_OUTPUT_METADA" property + * drm_connector_attach_hdr_output_metadata_property - attach "HDR_OUTPUT_METADATA" property * @connector: connector to attach the property on. * * This is used to allow the userspace to send HDR Metadata to the * driver. - * - * Returns: - * Zero on success, negative errno on failure. */ -int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector) +void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector) { struct drm_device *dev = connector->dev; struct drm_property *prop = dev->mode_config.hdr_output_metadata_property;drm_object_attach_property(&connector->base, prop, 0);- - return 0; } EXPORT_SYMBOL(drm_connector_attach_hdr_output_metadata_property);diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.hindex af8b92d2d5b7..c8dc08773a11 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -2518,7 +2518,7 @@ int drm_connector_attach_vrr_capable_property( void drm_connector_attach_panel_type_property(struct drm_connector *connector); int drm_connector_attach_broadcast_rgb_property(struct drm_connector *connector); int drm_connector_attach_colorspace_property(struct drm_connector *connector); -int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector); +void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector); bool drm_connector_atomic_hdr_metadata_equal(struct drm_connector_state *old_state, struct drm_connector_state *new_state); int drm_mode_create_aspect_ratio_property(struct drm_device *dev);
