Hi Liu, Thanks for the clarification.
On Wed, 6 May 2026 at 17:49, Liu Ying <[email protected]> wrote: > > > By "minimal" in v4 comment, I meant not to use __free(device_node) > in imx8qxp_pxl2dpi_get_available_ep_from_port() and > imx8qxp_pxl2dpi_set_pixel_link_sel() - please keep using > __free(device_node) in imx8qxp_pxl2dpi_find_next_bridge(). > > > > - Keep imx8qxp_pxl2dpi_get_available_ep_from_port() unchanged. > > No, please fix imx8qxp_pxl2dpi_get_available_ep_from_port() to make it > return int. > > > - Do not change imx8qxp_pxl2dpi_set_pixel_link_sel(). > > No, you need to change it. > > -- > Regards, > Liu Ying I misunderstood your previous comment. I will update the patch to keep using __free(device_node) in imx8qxp_pxl2dpi_find_next_bridge(), change imx8qxp_pxl2dpi_get_available_ep_from_port() to return int and pass the endpoint through an output argument, but avoid adding cleanup action usage in imx8qxp_pxl2dpi_get_available_ep_from_port() and imx8qxp_pxl2dpi_set_pixel_link_sel(). I will also drop the unnecessary local NULL initialization for ep, since the helper initializes the output argument to NULL. I will send a v6. Best regards, Guangshuo
