On Wed, May 06, 2026 at 02:25:37PM +0800, LiangCheng Wang wrote: > Add the compatible string for the PIXPAPER 4.26 monochrome > e-ink panel to the Mayqueen Pixpaper binding. > > The new panel uses the same SPI and GPIO control interface as > the existing Pixpaper panel, so extend the existing binding > instead of adding a separate schema. Document the new compatible > string and add an example node for pixpaper-426m. > > Signed-off-by: LiangCheng Wang <[email protected]> > --- > .../bindings/display/mayqueen,pixpaper.yaml | 25 > +++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml > b/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml > index > cd27f8ba5ae1d94660818525b5fa71db98c8acb7..4b0db2b079ebea244eb149a52ee1d8dbab0f60bb > 100644 > --- a/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml > +++ b/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml > @@ -4,22 +4,23 @@ > $id: http://devicetree.org/schemas/display/mayqueen,pixpaper.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Mayqueen Pixpaper e-ink display panel > +title: Mayqueen Pixpaper e-ink display panels > > maintainers: > - LiangCheng Wang <[email protected]> > > description: > - The Pixpaper is an e-ink display panel controlled via an SPI interface. > - The panel has a resolution of 122x250 pixels and requires GPIO pins for > - reset, busy, and data/command control. > + Mayqueen Pixpaper e-ink display panels are controlled via an SPI interface > + and require GPIO pins for reset, busy, and data/command control. > > allOf: > - $ref: /schemas/spi/spi-peripheral-props.yaml# > > properties: > compatible: > - const: mayqueen,pixpaper > + enum: > + - mayqueen,pixpaper > + - mayqueen,pixpaper-426m
The commit message makes it sound like both devices could be compatible,
but the diff says they are not. What actually makes them incompatible?
>
> reg:
> maxItems: 1
> @@ -61,3 +62,17 @@ examples:
> dc-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
> };
> };
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + display@0 {
> + compatible = "mayqueen,pixpaper-426m";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + reset-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
> + busy-gpios = <&gpio1 18 GPIO_ACTIVE_HIGH>;
> + dc-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
> + };
> + };
This example just duplicates the existing one, there's no value in
adding it.
pw-bot: changes-requested
Cheers,
Conor.
>
> --
> 2.34.1
>
signature.asc
Description: PGP signature
