Hi Liu, Thanks for the review.
On Thu, 7 May 2026 at 10:18, Liu Ying <[email protected]> wrote: > > On Wed, May 06, 2026 at 10:24:34PM +0800, Guangshuo Li wrote: > > [...] > > > Initialize the output > > argument to NULL so callers using cleanup variables hold either NULL or > > a valid device_node pointer on error paths. > > I'd rephrase: > Initialize the output argument to NULL so callers hold either NULL on > error paths or a valid device_node pointer on successful path. > > > > > Keep explicit of_node_put() usage in the helper and in > > imx8qxp_pxl2dpi_set_pixel_link_sel() so the fix avoids adding more > > cleanup action usage there. > > This sentence is not necessary, so I prefer to dropping it. > > With these fixed: > Reviewed-by: Liu Ying <[email protected]> > Thanks! > > -- > Regards, > Liu Ying I will rephrase that sentence as suggested and drop the unnecessary sentence in v7. Best regards, Guangshuo
