Hi Laurent, Thank you for the review.
On Wed, May 6, 2026 at 9:08 PM Laurent Pinchart <[email protected]> wrote: > > On Wed, Apr 29, 2026 at 06:00:10PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <[email protected]> > > > > Update the DU CRTC initialisation to request the reset control using > > devm_reset_control_get_optional_shared(). On RZ/T2H SoCs the DU block does > > not expose a reset line, and treating the reset as mandatory prevents the > > driver from probing on those platforms. > > This assume a device tree compliant with the bindings. In case of a > non-compliant device tree on platforms other than RZ/T2H, the driver may > silently fail to work as it won't complain about the lack of reset. I > think that's acceptable, as the reset should be specified in the SoC's > .dtsi. If if was the responsibility of board DT authors I would be a bit > more concerned. > I agree. Since the reset is expected to be defined in the SoC-level .dtsi and dtbs checks do complain if it is missed. Cheers, Prabhakar
