On Fri, May 08, 2026 at 12:44:23PM +0100, Daniel Golle wrote: > On Fri, May 08, 2026 at 02:29:29PM +0300, Dmitry Baryshkov wrote: > > On Thu, May 07, 2026 at 02:32:45PM +0100, Daniel Golle wrote: > > > On Thu, May 07, 2026 at 12:51:56PM +0300, Dmitry Baryshkov wrote: > > > > On Wed, Apr 15, 2026 at 04:04:16PM +0100, Daniel Golle wrote: > > > > > Notify hdmi-codec of the current sink plugged state from > > > > > mtk_hdmi_bridge_atomic_enable() and mtk_hdmi_bridge_atomic_disable() > > > > > via mtk_hdmi_update_plugged_status(). This matches the pattern used > > > > > by dw-hdmi, which invokes handle_plugged_change() from the bridge > > > > > enable and disable paths so that ASoC jack state stays in sync with > > > > > the actual sink presence across atomic commit cycles, and not only > > > > > on CEC HPD transitions. > > > > > > > > > > Userspace audio daemons (e.g. pipewire) rely on the jack state to > > > > > route streams, restore per-sink volume levels, and recover the last > > > > > used device after a reconnect. Without this, those transitions are > > > > > missed whenever the sink change is driven by a mode set rather than > > > > > by a bare HPD event. > > > > > > > > I can only hope to see mtk_hdmi to migrate to DRM_BRIDGE_OP_HDMI and > > > > DRM_BRIDGE_OP_HDMI_AUDIO... > > > > > > > > I think the correct timing was discussed several times and the overall > > > > conclusion was that the correct time is when the actual HDMI cable is > > > > being plugged / unplugged. See the discussion around [1] and the > > > > captured response of Mark Brown. > > > > > > Thank you for bringing this to my attention. I'll follow up on it. > > > Meanwhile, can (independent) patch 1/2 already be merged, or at least > > > get reviewed? > > > > > > The discussion that I pointed to suggests that the patch is incorrect. > > I understand that patch 2/2 is incorrect, but (the independent fix in) > patch 1/2 as well?
1/2 moves plugged updates to the atomic_enable() / atomic_disable(), which is not correct according to the discussion I pointed to. -- With best wishes Dmitry
