In armada_lcd_bind(), of_get_child_by_name() obtains a reference to
the "port" device_node which is passed to armada_drm_crtc_create().
On success, the reference is transferred to the crtc structure and
released later. However, if armada_drm_crtc_create() fails, the
function returns directly without releasing the port node, causing a
reference leak.
Fix by adding of_node_put(port) in the error path.
Fixes: 9611cb93fa65 ("drm/armada: register crtc with port")
Cc: [email protected]
Signed-off-by: Wentao Liang <[email protected]>
---
drivers/gpu/drm/armada/armada_crtc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_crtc.c
b/drivers/gpu/drm/armada/armada_crtc.c
index 0900e4466ffb..dfca664847b6 100644
--- a/drivers/gpu/drm/armada/armada_crtc.c
+++ b/drivers/gpu/drm/armada/armada_crtc.c
@@ -1035,7 +1035,10 @@ armada_lcd_bind(struct device *dev, struct device
*master, void *data)
}
}
- return armada_drm_crtc_create(drm, dev, res, irq, variant, port);
+ ret = armada_drm_crtc_create(drm, dev, res, irq, variant, port);
+ if (ret)
+ of_node_put(port);
+ return ret;
}
static void
--
2.34.1
