Hi, On Wed, May 6, 2026 at 10:06 AM Terry Hsiao <[email protected]> wrote: > > Correct the panel name for CMN 0x14d6 from N140BGA-EA4 to N140BGA-E54. > > Additionally, adjust the power sequence delay_200_500_e80_d50 to > delay_200_500_e80. > > CMN N140BGA-E54 > 00 ff ff ff ff ff ff 00 0d ae d6 14 00 00 00 00 > 22 21 01 04 95 1f 11 78 03 8e d5 94 57 53 93 27 > 21 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 da 1d 56 e2 50 00 20 30 2e 1e > a6 00 35 ad 10 00 00 1a e7 13 56 e2 50 00 20 30 > 2e 1e a6 00 35 ad 10 00 00 1a 00 00 00 00 00 00 > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02 > 00 0c 3d ff 0d 3c 7d 11 10 21 7d 00 00 00 00 3d > > Signed-off-by: Terry Hsiao <[email protected]> > --- > drivers/gpu/drm/panel/panel-edp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-edp.c > b/drivers/gpu/drm/panel/panel-edp.c > index 427a4b4c6712..295412ba13cd 100644 > --- a/drivers/gpu/drm/panel/panel-edp.c > +++ b/drivers/gpu/drm/panel/panel-edp.c > @@ -2069,7 +2069,7 @@ static const struct edp_panel_entry edp_panels[] = { > EDP_PANEL_ENTRY('C', 'M', 'N', 0x14a8, &delay_200_500_e80, > "N140JCA-ELP"), > EDP_PANEL_ENTRY('C', 'M', 'N', 0x14c7, &delay_200_500_e80, > "N140HCA-EEK"), > EDP_PANEL_ENTRY('C', 'M', 'N', 0x14d4, &delay_200_500_e80_d50, > "N140HCA-EAC"), > - EDP_PANEL_ENTRY('C', 'M', 'N', 0x14d6, &delay_200_500_e80_d50, > "N140BGA-EA4"), > + EDP_PANEL_ENTRY('C', 'M', 'N', 0x14d6, &delay_200_500_e80, > "N140BGA-E54"),
This makes me at least slightly nervous that the manufacturer might have used the same panel ID for more than one panel. ...but unfortunately the original entry was added here: http://lore.kernel.org/r/[email protected] ...and that was before we started including EDIDs in the commit message, so it's really hard to tell. :( It was also made during the big batch of panels added after the fact, so the chances are that the datasheet that Hsin-Yi was looking at was simply not quite right. So with all that, I think this should be OK. The string name doesn't matter a whole lot, and from my experience the disable timing isn't one of the most critical ones. ...so I'm going to go ahead and say it's fine to apply. Reviewed-by: Douglas Anderson <[email protected]> Pushed to drm-misc-next: [4/4] drm/panel-edp: Modify panel name and delay for CMN 0x14d6 commit: 9abe13a0598a8dae9a24c1cfea5643f8e12b49ed
