On Thu, May 14, 2026 at 01:20:57PM -0500, Aaron Kling wrote: > On Thu, May 14, 2026 at 1:07 PM Conor Dooley <[email protected]> wrote: > > > > On Thu, May 14, 2026 at 12:24:49PM -0500, Aaron Kling via B4 Relay wrote: > > > From: Aaron Kling <[email protected]> > > > > > > The Chipone ICNA35xx series of DDICs are high refresh, low power > > > MIPI-DSI drivers for OLED panels. The icna3512 is used by the Ayn Odin 2 > > > Portal and the icna3520 is used by the Ayn Thor top panel and the Ayn > > > Odin 3. > > > > > > Signed-off-by: Aaron Kling <[email protected]> > > > --- > > > .../bindings/display/panel/chipone,icna35xx.yaml | 79 > > > ++++++++++++++++++++++ > > > 1 file changed, 79 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml > > > b/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml > > > new file mode 100644 > > > index 00000000000000..6464d8d0cf86d5 > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml > > > > Filename matching a compatible please. > > Does this require splitting / duplicating the files for each ddic, or > can one be arbitrarily picked and the other stay with it?
Pick an arbitrary one. Maybe which one is older? > > > @@ -0,0 +1,79 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/panel/chipone,icna35xx.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Chipone ICNA35xx display drivers > > > + > > > +maintainers: > > > + - Neil Armstrong <[email protected]> > > > + > > > +description: > > > + The Chipone ICNA35xx are a series of DDICs connected > > > + using a MIPI-DSI video interface. > > > + > > > +allOf: > > > + - $ref: panel-common.yaml# > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > + - items: > > > + - enum: > > > + - ayaneo,pocketds-panel-top > > > + - ayntec,odin2portal-panel > > > + - const: chipone,icna3512 > > > + > > > + - items: > > > + - enum: > > > + - ayntec,odin3-panel > > > + - ayntec,thor-panel-top > > > + - const: chipone,icna3520 > > > > Commit message should state why these ddics are not compatible with one > > another. > > Ack. Short version: some of the mipi vendor commands don't match. > > > Rest of this seems okay. > > > > pw-bot: changes-requested > > > > Thanks, > > Conor. > > Aaron
signature.asc
Description: PGP signature
