Re: [PATCH 09/12] drm/vmwgfx: enforce cursor size limits for MOB cursors

[Zack Rusin]

On Thu, May 14, 2026 at 2:18 PM Ian Forbes <ian.for...@broadcom.com> wrote:
>
> On Tue, May 5, 2026 at 5:27 PM Zack Rusin <zack.ru...@broadcom.com> wrote:
> >
> > +
> > +               if (new_state->crtc_w > cursor_max_dim ||
> > +                   new_state->crtc_h > cursor_max_dim) {
> > +                       drm_warn(&vmw->drm,
> > +                                "Cursor dimensions (%d, %d) exceed device 
> > max %u\n",
> > +                                new_state->crtc_w, new_state->crtc_h,
> > +                                cursor_max_dim);
> > +                       return -EINVAL;
> > +               }
>
> we should probably just check against dev->mode_config.cursor_width as
> this is the maximum width userspace should be setting.

Not as is because we don't correctly set it. Only iff we fix that, we
could consider that. Even then we need a MOB_MAX_SIZE check, because I
don't think we can guarantee that SVGA_REG_CURSOR_MAX_DIMENSION always
fits in SVGA_REG_MOB_MAX_SIZE. Fixing mode_config cursor parameters
and ensuring they fit within svga's cursor and mob limits is a
separate change.

z

smime.p7s
Description: S/MIME Cryptographic Signature