On Wed, Apr 29, 2026 at 01:58:22PM +0200, Krzysztof Kozlowski wrote: > On Tue, Apr 28, 2026 at 02:54:53PM -0500, Chris Morgan wrote: > > On Tue, Apr 28, 2026 at 05:09:49PM +0200, Krzysztof Kozlowski wrote: > > > On 28/04/2026 16:09, Chris Morgan wrote: > > > > On Tue, Apr 28, 2026 at 09:47:00AM +0200, Krzysztof Kozlowski wrote: > > > >> On Mon, Apr 27, 2026 at 12:09:09PM -0500, Chris Morgan wrote: > > > >>> From: Chris Morgan <[email protected]> > > > >>> > > > >>> Document the SG Micro sgm41542 battery charger/boost converter. > > > >>> > > > >>> Signed-off-by: Chris Morgan <[email protected]> > > > >>> --- > > > >>> .../supply/sgmicro,sgm41542-charger.yaml | 99 > > > >>> +++++++++++++++++++ > > > >>> 1 file changed, 99 insertions(+) > > > >>> create mode 100644 > > > >>> Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542-charger.yaml > > > >>> > > > >>> diff --git > > > >>> a/Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542-charger.yaml > > > >>> > > > >>> b/Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542-charger.yaml > > > >>> new file mode 100644 > > > >>> index 000000000000..3e5041e5b551 > > > >>> --- /dev/null > > > >>> +++ > > > >>> b/Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542-charger.yaml > > > >> > > > >> Filename must match compatible. > > > > > > > > Acknowledged. > > > > > > > >> > > > >>> @@ -0,0 +1,99 @@ > > > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > >>> +%YAML 1.2 > > > >>> +--- > > > >>> +$id: > > > >>> http://devicetree.org/schemas/power/supply/sgmicro,sgm41542-charger.yaml# > > > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > >>> + > > > >>> +title: SGM41542 Battery Charger > > > >>> + > > > >>> +description: | > > > >> > > > >> Do not need '|' unless you need to preserve formatting. > > > >> > > > > > > > > Will fix. > > > > > > > >>> + The SGMicro SGM41542 is a single cell battery charger/boost > > > >>> controller. > > > >>> + > > > >>> +maintainers: > > > >>> + - Chris Morgan <[email protected]> > > > >>> + - Xu Shengfei <[email protected]> > > > >>> + > > > >>> +properties: > > > >>> + compatible: > > > >>> + const: sgmicro,sgm41542 > > > >>> + > > > >>> + input-current-limit-microamp: > > > >> > > > >> Missing vendor prefix. > > > >> > > > > > > > > This *appears* to be a standard value (perhaps not formally, but in use > > > > by > > > > enough devices to suggest a defacto standard), which is why I did not > > > > use > > > > the vendor prefix here. Do I need to add that for this one? > > > > > > I know, I found these other properties but I think they were just coming > > > from old schema. > > > > > > If it is really a common property, then should be defined in a common > > > schema and this did not happen. > > > > Would now be a good time to add it to the power-supply.yaml document? > > It looks like this value is used by about 10 other devices. > > I have mixed feelings. Adding it there would mean that all schemas using > unevaluatedProperties will get that property. That suggests they have > such limiting ability in hardware or this ABI is implemented in some > generic part of the kernel. > > None of these are true, I think. > > Maybe we need some documented guidance on usage of common schemas. > > Best regards, > Krzysztof
Would you recommend I just use the vendor prefix then here? Or add this to power supply as an option? Or is there a 3rd option you would like for me to pursue? Thank you, Chris > > > _______________________________________________ > Linux-rockchip mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-rockchip
