> -----Original Message-----
> From: Borah, Chaitanya Kumar <[email protected]>
> Sent: Wednesday, April 8, 2026 10:45 AM
> To: [email protected]; [email protected]; intel-
> [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Shankar,
> Uma <[email protected]>; Lankhorst, Maarten
> <[email protected]>; [email protected]; Samala,
> Pranay <[email protected]>; Sharma, Swati2
> <[email protected]>; Borah, Chaitanya Kumar
> <[email protected]>
> Subject: [PATCH v2 05/13] drm/i915/color: Fix HDR pre-CSC LUT programming
> loop
> 
> From: Pranay Samala <[email protected]>
> 
> The integer lut programming loop never executes completely due to incorrect
> condition (i++ > 130).
> 
> Fix to properly program 129th+ entries for values > 1.0.

Looks Good to me.
Reviewed-by: Uma Shankar <[email protected]>

> Cc: <[email protected]> #v6.19
> Fixes: 82caa1c8813f ("drm/i915/color: Program Pre-CSC registers")
> Signed-off-by: Pranay Samala <[email protected]>
> Signed-off-by: Chaitanya Kumar Borah <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_color.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c
> b/drivers/gpu/drm/i915/display/intel_color.c
> index e7950655434b..6d1cffc6d2be 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -3976,7 +3976,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb
> *dsb,
>                               intel_de_write_dsb(display, dsb,
> 
> PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
>                                                  (1 << 24));
> -                     } while (i++ > 130);
> +                     } while (i++ < 130);
>               } else {
>                       for (i = 0; i < lut_size; i++) {
>                               u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
> --
> 2.25.1

Reply via email to