Hi Dmitry, > Subject: Re: [PATCH v8 2/3] drm/virtio: Add support for saving and restoring > virtio_gpu_objects > > 29.04.2026 23:47, [email protected] пишет: > > void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo) { > > struct virtio_gpu_device *vgdev = bo->base.base.dev->dev_private; > @@ > > -94,6 +103,7 @@ static void virtio_gpu_free_object(struct drm_gem_object > *obj) > > struct virtio_gpu_device *vgdev = bo->base.base.dev->dev_private; > > > > if (bo->created) { > > + virtio_gpu_remove_from_restore_list(bo); > > virtio_gpu_cmd_unref_resource(vgdev, bo); > > Can virtio_gpu_remove_from_restore_list() be moved to > virtio_gpu_cmd_unref_resource()?
Yes, technically it can be done and we can remove some redundancy but don't you think adding it or removing it from the list would be better to be handled outside of vq functions (virtgpu_vq.c) where actual communication messages are processed? Thanks, DW > > -- > Best regards, > Dmitry
