On 5/20/2026 5:24 PM, Dmitry Baryshkov wrote:
On Tue, May 19, 2026 at 03:52:35PM +0800, Yongxing Mou wrote:
On 4/12/2026 1:38 AM, Dmitry Baryshkov wrote:
On Fri, Apr 10, 2026 at 05:33:43PM +0800, Yongxing Mou wrote:
From: Abhinav Kumar <[email protected]>
Currently, the dp_ctrl stream APIs operate on their own dp_panel
which is stored inside the dp_ctrl's private struct. However with MST,
the stored panel represents the fixed link and not the sinks which
are hotplugged. Allow the stream related APIs to work on the panel
which is passed to them rather than the stored one. For SST cases,
this shall continue to use the stored dp_panel.
Hmm. Why? Can't we get rid of it (in the followup patch)?
In MST, the stream panel is bound to the connector, but in SST the panel is
still stored in msm_dp_display_private and msm_dp_ctrl_private, so
dropping it does not seem necessary at this point. The purpose of these
changes is to allow the functions to operate on the MST panel data passed in
per stream.
I understand the panel being stored in msm_dp_display_private. Can we
drop it from msm_dp_ctrl_private?
Dropping panel from msm_dp_ctrl_private would require adding a panel
parameter to approximately 15 functions in dp_ctrl.c. Would you like us
to do that in this patch?
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Yongxing Mou <[email protected]>
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 21 +++++++++++----------
drivers/gpu/drm/msm/dp/dp_ctrl.h | 2 +-
drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
3 files changed, 13 insertions(+), 12 deletions(-)
