On Wed, May 20, 2026 at 04:03:42PM +0530, Mallesh, Koujalagi wrote: > On 14-05-2026 02:05 pm, Raag Jadav wrote: > > On Tue, May 12, 2026 at 06:56:20PM +0530, Mallesh Koujalagi wrote: > > > If the slot is not hotplug capable, pcie_suppress_surprise_link_down() > > > masks the Surprise Link Down bit (PCI_ERR_UNC_SURPDN) in the USP's AER > > > Uncorrectable Error Mask register before punit_error_handler() > > > triggers the cold reset.
... > > > +#ifdef CONFIG_PCIEAER > > > +static bool pcie_slot_is_hotplug_capable(struct pci_dev *usp) > > Shouldn't all of it be part of xe_pci_error.c? > Happy to relocate if/when a second caller appears, > but for now keeping them next to their sole user in xe_ras.c > seems cleaner. Open to other opinions though. We usually add the code to the component it's closest to, i.e. all the PCI stuff in xe_pci* files, but I'll leave it to you all. Raag
