On Tue, 12 May 2026 at 09:56, Laurent Pinchart <[email protected]> wrote: > > Hello, > > This patch series modernizes the VSP1 driver by using scoped guards and > moving loop index variable declarations to the loop statements. > > Patches 01/11 and 02/11 prepare for the introduction of scoped guards by > splitting a large function to lower the indentation level. As the > function is called by DRM clients (R-Car DU and RZ DU drivers), an > inline compatibility wrapper is introduced. The clients are then updated > in patches 03/11 and 04/11, and the compatibility wrapper removed in > 11/11. > > Patches 05/11 to 08/11 then introduce guards and scoped guards for > mutexes and spin locks. There isn't much to say about this, the changes > are pretty boring, but generate a nice reduction of 148 lines. I advise > reviewers to apply the changes and use 'git show -b', as a large part of > the modified lines in 06/11 and 08/11 are just indentation changes due > to scoped guards. > > Patch 09/11 continues with the introduction of a helper macro to > simplifying iteration over format arrays, which occurs 6 times in the > driver. Patch 10/11 ends the modernization effort with declaring index > variables in for loop statements to avoid using index variables outside > of the loop unintentionally. > > Patch 03/11 and 04/11 touch the DRM subsystem and depend on 02/11. They > could be delayed by one kernel release (in which case 11/11 would need > to be delayed by two releases), but I would prefer merging them through > the media tree if possible if there's no objection from the DRM > maintainers. I don't expect conflicting changes in the R-Car DU driver > for v7.2. Dave, Sima, could you give your ack for this ?
Acked-by: Dave Airlie <[email protected]> Dave.
