On 5/18/26 7:55 PM, Eliot Courtney wrote: > This is unused, so we can remove it. > > Reviewed-by: Joel Fernandes <[email protected]> > Signed-off-by: Eliot Courtney <[email protected]> > --- > drivers/gpu/nova-core/vbios.rs | 5 ----- > 1 file changed, 5 deletions(-)
Reviewed-by: John Hubbard <[email protected]> thanks, -- John Hubbard > > diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs > index 871f455bb720..8a0e16e6c9e8 100644 > --- a/drivers/gpu/nova-core/vbios.rs > +++ b/drivers/gpu/nova-core/vbios.rs > @@ -338,7 +338,6 @@ pub(crate) fn new(dev: &device::Device, bar0: &Bar0) -> > Result<Vbios> { > Ok(BiosImageType::FwSec) => { > let fwsec = FwSecBiosBuilder { > base: image, > - falcon_data_offset: None, > pmu_lookup_table: None, > falcon_ucode_offset: None, > }; > @@ -712,8 +711,6 @@ struct FwSecBiosBuilder { > /// Once FwSecBiosBuilder is constructed, the `falcon_ucode_offset` will > be copied into a new > /// [`FwSecBiosImage`]. > /// > - /// The offset of the Falcon data from the start of Fwsec image. > - falcon_data_offset: Option<usize>, > /// The [`PmuLookupTable`] starts at the offset of the falcon data > pointer. > pmu_lookup_table: Option<PmuLookupTable>, > /// The offset of the Falcon ucode. > @@ -1015,8 +1012,6 @@ fn setup_falcon_data( > offset -= first_fwsec.base.data.len(); > } > > - self.falcon_data_offset = Some(offset); > - > if pmu_in_first_fwsec { > self.pmu_lookup_table = Some(PmuLookupTable::new( > &self.base.dev, >
