Re: [PATCH NEXT 1/2] drm/radeon/radeon_connectors: use struct drm_edid instead of struct edid

[Joshua Peisach]

On Sat May 23, 2026 at 10:27 AM EDT, Joshua Peisach wrote:

@@ -280,19 +280,19 @@ static void radeon_connector_get_edid(struct 
drm_connector *connector)
                if ((dig->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT ||
                     dig->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) &&
                    radeon_connector->ddc_bus->has_aux)
-                       radeon_connector->edid = 
drm_get_edid(&radeon_connector->base,
-                                                             
&radeon_connector->ddc_bus->aux.ddc);
+                       radeon_connector->edid = 
drm_edid_read_ddc(&radeon_connector->base,
+                                                                  
&radeon_connector->ddc_bus->aux.ddc);
                else if (radeon_connector->ddc_bus)
-                       radeon_connector->edid = 
drm_get_edid(&radeon_connector->base,
-                                                             
&radeon_connector->ddc_bus->adapter);
+                       radeon_connector->edid = 
drm_edid_read_ddc(&radeon_connector->base,
+                                                                  
&radeon_connector->ddc_bus->adapter);
        } else if (vga_switcheroo_handler_flags() & VGA_SWITCHEROO_CAN_SWITCH_DDC 
&&
                   connector->connector_type == DRM_MODE_CONNECTOR_LVDS &&
                   radeon_connector->ddc_bus) {
-               radeon_connector->edid = 
drm_get_edid_switcheroo(&radeon_connector->base,
-                                                                
&radeon_connector->ddc_bus->adapter);
+               radeon_connector->edid = 
drm_edid_read_switcheroo(&radeon_connector->base,
+                                                                 
&radeon_connector->ddc_bus->adapter);
        } else if (radeon_connector->ddc_bus) {
-               radeon_connector->edid = drm_get_edid(&radeon_connector->base,
-                                                     
&radeon_connector->ddc_bus->adapter);
+               radeon_connector->edid = 
drm_edid_read_ddc(&radeon_connector->base,
+                                                          
&radeon_connector->ddc_bus->adapter);
        }

Question: For all of these, should we actually call with connector
instead of &radeon_connector->base?