> commit 2d7f05cddf4c268cc36256a2476946041dbdd36d upstream. > > The runtime PM suspend callback doesn't know whether the IRQ handler is > in progress on a different CPU core and doesn't wait for it to finish. > [...] > This version of the patch contains only the part of the upstream commit > that applies to 6.12; the rest was a revert of code added in 6.16.
The diff itself is fine and the synchronize_irq() portion is exactly what we want on 6.12.y. However, the backport drops several trailers from the upstream commit that we'd like to preserve verbatim on stable: - Reviewed-by: Matt Coster <[email protected]> - Link: https://patch.msgid.link/... (the upstream Link: trailer) - Signed-off-by: Matthew Brost (the upstream maintainer SoB that landed the patch upstream) The upstream Fixes: tag also lists two entries: Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware ...") Fixes: 96822d38ff57 ("drm/imagination: Implement Rogue safety event IRQs") Your backport keeps only the first. I agree the second Fixes: refers to code that doesn't exist on 6.12, but please keep it in the commit message anyway so the trailers match upstream verbatim; stable convention is to preserve the upstream trailer block unchanged. Could you send a v2 with the upstream trailers (Reviewed-by, Link, SoB, both Fixes:) restored? -- Thanks, Sasha
