On 5/24/26 12:33 PM, Dmitry Baryshkov wrote: > Tracking when the DP link is ready isn't that useful from the driver > point of view. It doesn't provide a direct information if the device > should be suspended, etc. Replace it with the 'plugged' boolean, which > is set when the driver knows that there is DPRX plugged. > > Tested-by: Val Packett <[email protected]> # x1e80100-dell-latitude-7455 > Tested-by: Yongxing Mou <[email protected]> # Hamoa IOT EVK, > QCS8300 Ride > Signed-off-by: Dmitry Baryshkov <[email protected]> > ---
[...] > -static void msm_dp_display_host_phy_init(struct msm_dp_display_private *dp) > +/** > + * msm_dp_display_host_phy_init() - start up DP PHY > + * @dp: main display data structure > + * > + * Prepare DP PHY for the AUX transactions to succeed. > + * > + * Returns: true if this call has initliazed the PHY and false if the PHY has > + * already been setup beforehand. This assumes no failure. I hope adding various return-value checks across this driver is somewhere on the todolist.. [...] > end: > - pm_runtime_put_sync(&dp->pdev->dev); > + /* > + * If we detected the DPRX, leave the controller on so that it doesn't > + * loose the state. "lose" That is done.. presumably so that one could correct a coredump or similar? Konrad
