From: AlbertoArostegui <[email protected]>

pxa168fb maps the LCD controller register resource with devm_ioremap(),
which does not request the memory region. Use devm_ioremap_resource()
instead so the MMIO range is claimed before being mapped.

This also handles cleanup automatically.

Signed-off-by: AlbertoArostegui <[email protected]>
---
 drivers/video/fbdev/pxa168fb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index ec602f7776eb..6784888d93c9 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -653,10 +653,9 @@ static int pxa168fb_probe(struct platform_device *pdev)
        /*
         * Map LCD controller registers.
         */
-       fbi->reg_base = devm_ioremap(&pdev->dev, res->start,
-                                            resource_size(res));
-       if (fbi->reg_base == NULL) {
-               ret = -ENOMEM;
+       fbi->reg_base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(fbi->reg_base)) {
+               ret = PTR_ERR(fbi->reg_base);
                goto failed_free_info;
        }
 
-- 
2.43.0

Reply via email to