On Thu, 2026-05-28 at 19:56 +0200, Danilo Krummrich wrote: > I think at least this patch has to be reverted, it causes the following oops > probing nouveau on my machine. > > I can't currently look into this, but I think Sashiko [1] has a valid point on > this one.
I'm not a fan of this series. When I saw the number of patches, I was suspicious, because I have a hard time believing that there were so many functions that never returned NULL. The call tree of a lot of Nouveau code is pretty deep, and it takes quite a lot of work to ensure that there is no "return NULL" in any code path. Nouveau is kinda sloppy in this regard, which is why IS_ERR_OR_NULL is used so much. It's a safety measure.
