On Wed, May 4, 2011 at 11:52 PM, Ilija Hadzic
<ihadzic at research.bell-labs.com> wrote:
> the crtc check in radeon_get_vblank_timestamp_kms should be against
> the num_crtc field in radeon_device not against num_crtcs in drm_device
> like it's done in all other functions that handle crtc
>
Looks good to me. Mario, any reason why we should use the dev version
rather than the rdev version?
Reviewed-by: Alex Deucher <alexdeucher at gmail.com>
> Signed-off-by: Ilija Hadzic <ihadzic at research.bell-labs.com>
> ---
> ?drivers/gpu/drm/radeon/radeon_kms.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c
> b/drivers/gpu/drm/radeon/radeon_kms.c
> index 871df03..f9e968f 100644
> --- a/drivers/gpu/drm/radeon/radeon_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> @@ -331,7 +331,7 @@ int radeon_get_vblank_timestamp_kms(struct drm_device
> *dev, int crtc,
> ? ? ? ?struct drm_crtc *drmcrtc;
> ? ? ? ?struct radeon_device *rdev = dev->dev_private;
>
> - ? ? ? if (crtc < 0 || crtc >= dev->num_crtcs) {
> + ? ? ? if (crtc < 0 || crtc >= rdev->num_crtc) {
> ? ? ? ? ? ? ? ?DRM_ERROR("Invalid crtc %d\n", crtc);
> ? ? ? ? ? ? ? ?return -EINVAL;
> ? ? ? ?}
> --
> 1.7.4.1
>
>
