Re: [PATCH v2 4/4] drm/xe/hw_error: Use HW_ERR prefix in log

[Michal Wajdeczko]

On 5/23/2026 7:00 AM, Raag Jadav wrote:
> Hardware errors should be logged with HW_ERR prefix. Make them
> consistent with existing logs.
> 
> Fixes: 01aab7e1c9d4 ("drm/xe/xe_hw_error: Add support for PVC SoC errors")
> Signed-off-by: Raag Jadav <raag.ja...@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_hw_error.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_error.c 
> b/drivers/gpu/drm/xe/xe_hw_error.c
> index 5135e8e4093f..4b72959b2276 100644
> --- a/drivers/gpu/drm/xe/xe_hw_error.c
> +++ b/drivers/gpu/drm/xe/xe_hw_error.c
> @@ -223,9 +223,9 @@ static void log_hw_error(struct xe_tile *tile, const char 
> *name,
>       struct xe_device *xe = tile_to_xe(tile);
>  
>       if (severity == DRM_XE_RAS_ERR_SEV_CORRECTABLE)
> -             drm_warn(&xe->drm, "%s %s detected\n", name, severity_str);
> +             drm_warn(&xe->drm, HW_ERR "%s %s detected\n", name, 
> severity_str);

function is per-tile, so shouldn't we use tile-oriented logs instead?

                xe_tile_warn(tile, HW_ERR ...)

>       else
> -             drm_err_ratelimited(&xe->drm, "%s %s detected\n", name, 
> severity_str);
> +             drm_err_ratelimited(&xe->drm, HW_ERR "%s %s detected\n", name, 
> severity_str);

                xe_tile_err_ratelimited(tile, HW_ERR ...)

>  }
>  
>  static void log_gt_err(struct xe_tile *tile, const char *name, int i, u32 
> err,
> @@ -235,10 +235,10 @@ static void log_gt_err(struct xe_tile *tile, const char 
> *name, int i, u32 err,
>       struct xe_device *xe = tile_to_xe(tile);
>  
>       if (severity == DRM_XE_RAS_ERR_SEV_CORRECTABLE)
> -             drm_warn(&xe->drm, "%s %s detected, 
> ERROR_STAT_GT_VECTOR%d:0x%08x\n",
> +             drm_warn(&xe->drm, HW_ERR "%s %s detected, 
> ERROR_STAT_GT_VECTOR%d:0x%08x\n",
>                        name, severity_str, i, err);
>       else
> -             drm_err_ratelimited(&xe->drm, "%s %s detected, 
> ERROR_STAT_GT_VECTOR%d:0x%08x\n",
> +             drm_err_ratelimited(&xe->drm, HW_ERR "%s %s detected, 
> ERROR_STAT_GT_VECTOR%d:0x%08x\n",
>                                   name, severity_str, i, err);
>  }
>  
> @@ -255,9 +255,9 @@ static void log_soc_error(struct xe_tile *tile, const 
> char * const *reg_info,
>  
>       if (strcmp(name, "Undefined")) {
>               if (severity == DRM_XE_RAS_ERR_SEV_CORRECTABLE)
> -                     drm_warn(&xe->drm, "%s SOC %s detected", name, 
> severity_str);
> +                     drm_warn(&xe->drm, HW_ERR "%s SOC %s detected", name, 
> severity_str);
>               else
> -                     drm_err_ratelimited(&xe->drm, "%s SOC %s detected", 
> name, severity_str);
> +                     drm_err_ratelimited(&xe->drm, HW_ERR "%s SOC %s 
> detected", name, severity_str);
>               atomic_inc(&info[index].counter);
>       }
>  }